[Improve][Sort] New so many MetricsController obejects - Githubissues

apache / inlong

Apache InLong - a one-stop, full-scenario integration framework for massive data

https://inlong.apache.org/

Apache License 2.0

1.39k stars 530 forks source link

[Improve][Sort] New so many MetricsController obejects #10240

Open XiaoYou201 opened 5 months ago

XiaoYou201 commented 5 months ago

Description

The audit information will report when every records deserializing, So,it will new many MetricsController objects.

https://github.com/apache/inlong/blob/03c2160411d171b7ee4fc00430938cf7aac457d6/inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/PulsarTableDeserializationSchema.java#L99-L118

And MetricController not has SinkMetricData property, So, it should be add to MetricController

https://github.com/apache/inlong/blob/03c2160411d171b7ee4fc00430938cf7aac457d6/inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/MetricsCollector.java#L28-L35

https://github.com/apache/inlong/blob/03c2160411d171b7ee4fc00430938cf7aac457d6/inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/SinkMetricData.java#L45-L60

InLong Component

InLong Sort

Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 60 days with no activity.