[Improve] Remove commitlint in package.json

apache / inlong

Apache InLong - a one-stop, full-scenario integration framework for massive data

https://inlong.apache.org/

Apache License 2.0

1.4k stars 530 forks source link

[Improve] Remove commitlint in package.json #1628

Closed ruanwenjun closed 3 years ago

ruanwenjun commented 3 years ago

Description

After install the front end, the commitlint will check the git commit message format, this may not be needed, since it's can be forced by --no-verify. And this is not announced in docs.

https://github.com/apache/incubator-inlong/blob/7f7859a1248b6e95e414aa76b63166f8b89436b8/inlong-website/package.json#L56-L75

Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

ruanwenjun commented 3 years ago

@leezng Please take a look.

leezng commented 3 years ago

I agree that the commit lint of the front-end project can be removed, just follow the unified rules of the project.

ruanwenjun commented 3 years ago

Yes, right now the commit message is [INLONG-xx] xx, this is not consistent with commit lint. And if we hope to set the rule of commit message, we should announce in the contribution doc first.

At last, it's better not set many rules for the commit message, the commit message can be modified by committer when committer merge pr.