search

apache / jena

Apache Jena
https://jena.apache.org/
Apache License 2.0
1.12k stars 653 forks source link

Incorporate the rdf-tables and expiring-map code in Jena GeoSPARQL. #2036

Closed afs closed 1 year ago

afs commented 1 year ago

Jena's GeoSPARQL support relies on two Apache-licensed packages rdf-tables and expiring-map.

These package were last released Jan 29, 2019

galbiston has done a fantastic job on GeoSPARQL.

Some of the Jena5 changes (TDB1 renames) impact these packages and dependency version differences have "just happened to work".

It seems safer to incorporate the code from these two packages into Jena's codebase so that they track Jena.

Put under org.apache.jena.ext.io.github.galbiston.... which makes it easily reversible.

(The expiring map can probably be replaced by a Caffeine cache with entry expiry.)

rvesse commented 1 year ago

If we're pulling the rdf-tables library in could we modify it to use Caffeine instead of expiring-map as the latter looks to be a minimal subset of functionality we already get from Caffeine?

afs commented 1 year ago

@rvesse Yes, I think we could.

afs commented 1 year ago

Closed by #2029.

afs commented 1 year ago

Issue #2048 is for replacing ExpiringMap with a Caffeine based cache.