GH-2753: Customize Fuseki main arguments - Githubissues

apache / jena

Apache Jena

https://jena.apache.org/

Apache License 2.0

1.12k stars 652 forks source link

GH-2753: Customize Fuseki main arguments #2845

Closed afs closed 2 days ago

afs commented 1 week ago

GitHub issue resolved #2753

[x] Tests are included.
[ ] Documentation change and updates are provided for the Apache Jena website
[ ] Commits have been squashed to remove intermediate development commit messages.
[x] Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.

See the Apache Jena "Contributing" guide.

afs commented 2 days ago

Looks good to me, and looking at the test cases this covers all the scenarios that motivated my original ticket #2753

There a few niggles in the command argument processing that could be improved and the overall system assumes a degree of cooperation between elements not to tread on each other. These are best dealt with from experience.

The one I notice that might help management of servers services is to have arguments in a file, and then have a command line of @my-fuseki.args to read them in (and no other arguments on the command line).

afs commented 2 days ago

Apologies - I forgot to push the fixes mentioned above. I'll include them in an args clearup PR.