apache / jmeter

Apache JMeter open-source load testing tool for analyzing and measuring the performance of a variety of services
https://jmeter.apache.org/
Apache License 2.0
8.11k stars 2.06k forks source link

FileServer should provide thread-safe parsing #2908

Closed asfimport closed 11 years ago

asfimport commented 11 years ago

Sebb (Bug 53806): At present, FileServer only provides access to read a single line.

This makes it difficult to enhance CSV DataSet to handle embedded new-lines.

It would be useful to provide access to the BufferedReader. This would not need to handle file restart, as it does not make sense for a single CSV record to be split across a file boundary.

See also https://github.com/apache/jmeter/issues/2907.

OS: All

Blocks:

asfimport commented 11 years ago

Sebb (migrated from Bugzilla): Just realised that it won't work as orginally envisaged - there needs to be a lock to ensure that only a single thread can read multiple consecutive lines.

The functionality is still needed, but will need to be provided some other way, for example via a callback mechanism. Details TBA.

asfimport commented 11 years ago

Sebb (migrated from Bugzilla): One way round this is to provide access to the reader, but require the caller to synchronise on the FileServer instance.

This is not ideal, as it means locking is not totally controlled by the FileServer class.

asfimport commented 11 years ago

Sebb (migrated from Bugzilla): URL: http://svn.apache.org/viewvc?rev=1384590&view=rev Log: FileServer should provide direct access to the BufferedReader https://github.com/apache/jmeter/issues/2908

Modified: jmeter/trunk/src/core/org/apache/jmeter/services/FileServer.java jmeter/trunk/xdocs/changes.xml

asfimport commented 11 years ago

Sebb (migrated from Bugzilla): Rather than provide access to the buffered reader, it would be easier to control synchronisation if FileServer provided the data as a CSV parsed String array.

asfimport commented 11 years ago

Sebb (migrated from Bugzilla): URL: http://svn.apache.org/viewvc?rev=1386736&view=rev Log: FileServer should provide thread-safe parsing https://github.com/apache/jmeter/issues/2908

Modified: jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSet.java jmeter/trunk/src/core/org/apache/jmeter/services/FileServer.java jmeter/trunk/xdocs/changes.xml