search

apache / jmeter

Apache JMeter open-source load testing tool for analyzing and measuring the performance of a variety of services
https://jmeter.apache.org/
Apache License 2.0
8.41k stars 2.1k forks source link

Handle IE Conditional comments when parsing embedded resources #3404

Open asfimport opened 10 years ago

asfimport commented 10 years ago

Irshad Ahmad (Bug 56772): Hi Team,

Jmeter is downloading sub requests wihci is if IE 8 only javascript , even though User-Agent is Chrome 30.

OS: All

asfimport commented 10 years ago

Sebb (migrated from Bugzilla): Please provide sample URL that exhibits the problem.

asfimport commented 10 years ago

@pmouawad (migrated from Bugzilla): I think what is being reported here relates to embedded resources download. In this case I suppose there is javascript in conditional block dedicated to IE8 browser. Is the download feature supposed to handle this ?

asfimport commented 10 years ago

Sebb (migrated from Bugzilla): (In reply to Philippe Mouawad from comment 2)

I think what is being reported here relates to embedded resources download. In this case I suppose there is javascript in conditional block dedicated to IE8 browser.

Looks like it

Is the download feature supposed to handle this ?

JMeter does not interpret javascript so almost certainly it cannot detect this.

I wonder if all browsers detect it? Without a test sample it's hard to know.

asfimport commented 10 years ago

Irshad Ahmad (migrated from Bugzilla): Hi Team,

Sorry for Late reply and Due to Security issues I cannot share the Application URL, Below is the explanation, let me know If you require anything else.

@Philippe Mouawad : Yes this is about the embedded URL, Actually in Chrome browser this Specific IE8 only js is not downloading, Jmeter User-Agent is set to Chrome 30, but Jmeter is downloading this js file and which is leading to 404 Error. Since 404 error is the issue for Load Test and we are unable to supress the same.

I have below queries.

  1. Is there any way in Jmeter we can avoid specific embedded resources?
  2. Is there any problem with User-Agent settings?

and this is happening only in Jmeter 10 & 11, but Jmeter 9 works fine:)

asfimport commented 10 years ago

Sebb (migrated from Bugzilla): (In reply to Irshad Ahmad from comment 4)

Hi Team,

Sorry for Late reply and Due to Security issues I cannot share the Application URL, Below is the explanation, let me know If you require anything else.

Can you share the offending HTML? The URLs and any other content can be redacted so long as the syntax/structure is retained.

@Philippe Mouawad : Yes this is about the embedded URL, Actually in Chrome browser this Specific IE8 only js is not downloading, Jmeter User-Agent is set to Chrome 30, but Jmeter is downloading this js file and which is leading to 404 Error. Since 404 error is the issue for Load Test and we are unable to supress the same.

I have below queries.

  1. Is there any way in Jmeter we can avoid specific embedded resources?

http://jmeter.apache.org/usermanual/component_reference.html#HTTP_Request See "Embedded URLs must match"

It looks like the following RE should match all but your URL:

^(?!regex)

where regex matches the URL.

  1. Is there any problem with User-Agent settings?

JMeter does not change its behaviour based on the User Agent, but your server might.

and this is happening only in Jmeter 10 & 11, but Jmeter 9 works fine:)

Probably JMeter 2.9 fails to extract the embedded URL, but without the sample HTML it's impossible to say.

asfimport commented 10 years ago

@pmouawad (migrated from Bugzilla): @Ahmad, can you provide request elements by sebb ? Otherwise we won't be able to fix bug

Thanks

asfimport commented 10 years ago

@pmouawad (migrated from Bugzilla): I reproduced issue. In fact the issue comes from switching : htmlParser.className=org.apache.jmeter.protocol.http.parser.HtmlParserHTMLParser to htmlParser.className=org.apache.jmeter.protocol.http.parser.LagartoBasedHtmlParser

since JMeter 2.10.

What happens is that HtmlParserHTMLParser simply ignored or was not able to parse correctly this kind of html: <!--[if lte IE 8]> <link rel="stylesheet" type="text/css" href="./ie8-and-down.css" /> <![endif]-->

So it didn't extract the link. New parser knows how to extract it.

As a workaround you can switch to : htmlParser.className=org.apache.jmeter.protocol.http.parser.LagartoBasedHtmlParser

@JMeter Dev Team: To fix issue we need to add user agent as a parameter of HTMLParser#getEmbeddedResourceURLs And then for example with Lagarto :

where enabled controls wether addition to list of urls to parse should occur or not

asfimport commented 10 years ago

@pmouawad (migrated from Bugzilla): Date: Sun Aug 24 21:09:04 2014 New Revision: 1620188

URL: http://svn.apache.org/r1620188 Log: https://github.com/apache/jmeter/issues/3404 - Handle IE Conditional comments when parsing embedded resources https://github.com/apache/jmeter/issues/3404

Added: jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1.html (with props) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_FF.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_IE6.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_IE7.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_IE8.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2.html (with props) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_FF.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_IE7.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_IE8.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_IE9.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3.html (with props) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_FF.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_IE10.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_IE55.all jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_IE6.all Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HTMLParser.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParserHTMLParser.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/JTidyHTMLParser.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/JsoupBasedHtmlParser.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/LagartoBasedHtmlParser.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/RegexpHTMLParser.java jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestHTMLParser.java jmeter/trunk/xdocs/changes.xml

Date: Sun Aug 24 21:18:30 2014 New Revision: 1620189

URL: http://svn.apache.org/r1620189 Log: https://github.com/apache/jmeter/issues/3404 - Handle IE Conditional comments when parsing embedded resources Upgrade to Jodd 3.6.0-BETA2 as conditional comments have been introduced in BETA1 (some useful extra classes like HtmlCCommentExpressionMatcher) https://github.com/apache/jmeter/issues/3404

Added: jmeter/trunk/licenses/bin/jodd-core-3.6.0-BETA2.txt (contents, props changed)

Date: Sun Aug 24 21:20:16 2014 New Revision: 1620190

URL: http://svn.apache.org/r1620190 Log: https://github.com/apache/jmeter/issues/3404 - Handle IE Conditional comments when parsing embedded resources svn eol https://github.com/apache/jmeter/issues/3404

Modified: jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1.html (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_FF.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_IE6.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_IE7.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional1_IE8.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2.html (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_FF.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_IE7.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_IE8.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional2_IE9.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3.html (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_FF.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_IE10.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_IE55.all (props changed) jmeter/trunk/bin/testfiles/HTMLParserTestCaseWithConditional3_IE6.all (props changed)

Date: Sun Aug 24 21:25:16 2014 New Revision: 1620191

URL: http://svn.apache.org/r1620191 Log: https://github.com/apache/jmeter/issues/3404 - Handle IE Conditional comments when parsing embedded resources Upgrade to Jodd 3.6.0-BETA2 https://github.com/apache/jmeter/issues/3404

Added: jmeter/trunk/lib/mongo-java-driver-2.12.3.jar (with props) jmeter/trunk/lib/xstream-1.4.6.jar (with props) Modified: jmeter/trunk/lib/ (props changed) jmeter/trunk/lib/aareadme.txt

asfimport commented 10 years ago

@pmouawad (migrated from Bugzilla): Resolved for Lagarto implementation. For JSoup waiting for answers from group. For other implementation not sure it is useful to implement this feature.