Open asfimport opened 9 years ago
Tomasz Skórka (migrated from Bugzilla): Adding patch for java and docs.
Created attachment jmeter-trunk_bug57539.patch: patch_57539
Tomasz Skórka (migrated from Bugzilla): Created attachment tcpsampler.png: docs screenshoot update
@milamberspace (migrated from Bugzilla):
Thanks for your patch.
Some comments:
To solve this issue on JMeter, HTTP Sampler or Mail Sampler accepts all SSL certificate (See class like TrustAllSSLSocketFactory)
The documentation must be inserted in component_reference.xml (<-- XML) not .html. The HTML file is automatically generated by the build script (ant tasks: docs, printable_docs)
I think that the key in messages.properties for the checkbox label SSL must be "tcp_usessl" (not just only "usessl"). The value can be "Use SSL" too (seems better)
In the GUI, I think that the "Use SSL" checkbox can be at the first position (before Re-use connection)
In TCPConfigGui.java, remove the 'new' comment's lines ("// useSsl.addItemListener(new ItemListener() {....). not need I think.
In TCPSampler.java, in the method " public SampleResult sample(Entry e)", add to the StringBuilder sb, the key/value for Use SSL (before the reuse value)
Thanks.
Tomasz Skórka (Bug 57539): TCP sampler should also support secure sockets, as systems that use this connectivity method still exist. From UI perspective a simple checkbox labeled "SSL" would do. JKS can be provided by cmd line parameters (javax.net.ssl.*).
Votes in Bugzilla: 1 OS: All