apache / jmeter

Apache JMeter open-source load testing tool for analyzing and measuring the performance of a variety of services
https://jmeter.apache.org/
Apache License 2.0
8.4k stars 2.1k forks source link

New fields/changed defaults cause earlier test plans to be marked as changed #3901

Closed asfimport closed 8 years ago

asfimport commented 8 years ago

Sebb (Bug 59173): Create a Test Plan with JMeter 2.13 containing:

Access Log Sampler JMS Publisher Regular Expression Extractor Backend Listener

Open it in JMeter trunk version.

View one or more of the test elements - don't change anything - and then select the Test Plan.

Press Quit; it will prompt to save the changed Test Plan.

If you save the plan to a new file and compare the files, there are several differences.

There are two causes:

It's disconcerting to be warned that the test plan has changed when that is not the case. The issue will keep occurring until test plans using any of those elements have been updated.

This bug means that test plans are not properly upwards-compatible.

Version: Nightly Severity: normal OS: All

Blocks:

asfimport commented 8 years ago

Sebb (migrated from Bugzilla): Created attachment JMXChanges.jmx: Test plan created in JMeter 2.13

JMXChanges.jmx ````xml false false continue false 1 1 1 1457826177000 1457826177000 false false org.apache.jmeter.protocol.http.util.accesslog.TCLogParser false jms_use_text jms_text_message 1 false false graphiteMetricsSender org.apache.jmeter.visualizers.backend.graphite.TextGraphiteMetricsSender = graphiteHost = graphitePort 2003 = rootMetricsPrefix jmeter. = summaryOnly true = samplersList = percentiles 90;95;99 = org.apache.jmeter.visualizers.backend.graphite.GraphiteBackendListenerClient ````
asfimport commented 8 years ago

Sebb (migrated from Bugzilla): Created attachment JMXChanges_30.jmx: Test plan saved with JMeter trunk

JMXChanges_30.jmx ````xml false false continue false 1 1 1 1457826177000 1457826177000 false false org.apache.jmeter.protocol.http.util.accesslog.TCLogParser http false jms_use_text jms_text_message 1 false false false graphiteMetricsSender org.apache.jmeter.visualizers.backend.graphite.TextGraphiteMetricsSender = graphiteHost = graphitePort 2003 = rootMetricsPrefix jmeter. = summaryOnly true = samplersList = useRegexpForSamplersList false = percentiles 90;95;99 = org.apache.jmeter.visualizers.backend.graphite.GraphiteBackendListenerClient ````
asfimport commented 8 years ago

@pmouawad (migrated from Bugzilla): Author: pmouawad Date: Tue Mar 15 21:37:38 2016 New Revision: 1735170

URL: http://svn.apache.org/viewvc?rev=1735170&view=rev Log: https://github.com/apache/jmeter/issues/3901 - New fields/changed defaults cause earlier test plans to be marked as changed Fix RegExtractor saving with 3.0 https://github.com/apache/jmeter/issues/3901

Modified: jmeter/trunk/src/components/org/apache/jmeter/extractor/RegexExtractor.java

asfimport commented 8 years ago

@pmouawad (migrated from Bugzilla): 1/ For AccessLogSample, new protocol field was introduced, it doesn't hurt me that JMeter asks user to save. But if you see how to fix it, go ahead.

2/ For Backend Listener, again a new parameter was introduced, I am not sure we can fix the saving so that this new fields is not appended.

3/ For JMS Publisher, I am not sure it can be properly fixed as in 2.13, we made a mistake in the way we managed JMS Priority and JMS Expiry default values. But if you see how to fix it, go ahead

asfimport commented 8 years ago

Sebb (migrated from Bugzilla): URL: http://svn.apache.org/viewvc?rev=1735765&view=rev Log: New fields/changed defaults cause earlier test plans to be marked as changed Fix AccessLogSampler; added TestBean support for not saving default values https://github.com/apache/jmeter/issues/3901

Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/BeanInfoSupport.java jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerBeanInfo.java

asfimport commented 8 years ago

Sebb (migrated from Bugzilla): URL: http://svn.apache.org/viewvc?rev=1735776&view=rev Log: New fields/changed defaults cause earlier test plans to be marked as changed Fix PublisherSampler: convert default to empty string on output (as that is what the input methods do) https://github.com/apache/jmeter/issues/3901

Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java

asfimport commented 8 years ago

Sebb (migrated from Bugzilla): Note: this bug applies to nightlies after 2.13

asfimport commented 8 years ago

Sebb (migrated from Bugzilla): URL: http://svn.apache.org/viewvc?rev=1736119&view=rev Log: New fields/changed defaults cause earlier test plans to be marked as changed Fix BackendListener https://github.com/apache/jmeter/issues/3901

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

asfimport commented 8 years ago

@pmouawad (migrated from Bugzilla): Date: Sun Mar 27 19:33:47 2016 New Revision: 1736811

URL: http://svn.apache.org/viewvc?rev=1736811&view=rev Log: https://github.com/apache/jmeter/issues/3901 - New fields/changed defaults cause earlier test plans to be marked as changed https://github.com/apache/jmeter/issues/3901

Modified: jmeter/trunk/xdocs/changes.xml