apache / jmeter

Apache JMeter open-source load testing tool for analyzing and measuring the performance of a variety of services
https://jmeter.apache.org/
Apache License 2.0
8.26k stars 2.09k forks source link

View Results Tree : Different character sizes (All version of JMeter) #5263

Open asfimport opened 4 years ago

asfimport commented 4 years ago

Markowski_JM (Bug 64248): Hi,

I send you the document with all the differences of character sizes and background in View Results Tree.

I use the version apache-jmeter-5.3-SNAPSHOT from 2020-03-19 with Darklaf solarized light

To standardize the size of the characters, it's possible to keep the large size among the 4 samples in document.

Thanks.

Created attachment View Results Tree.pdf: Print screen of character sizes

Version: Nightly Severity: normal OS: All

asfimport commented 4 years ago

@vlsi (migrated from Bugzilla): The issue there is "Response data" uses org.apache.jmeter.visualizers.SearchTextExtension#SearchTextExtension while "Request data" uses org.apache.jmeter.gui.util.JSyntaxSearchToolBar#JSyntaxSearchToolBar

In other words, it looks like code duplication with a slightly different implementation.

There's one more issue: search toolbar can't be zoomed because it uses a hard-coded font size.

I think we should factor FONT_SMALL and friends to UIDefautls, then we can consistently update it for LaF and zoom purposes.

asfimport commented 4 years ago

@vlsi (migrated from Bugzilla): I wonder if the search panel should appear only when ctrl+f / cmd+f is pressed.

asfimport commented 4 years ago

@pmouawad (migrated from Bugzilla): @Vladimir, Can you confirm this is fixed by:

https://github.com/apache/jmeter/pull/572

Thanks