Closed asfimport closed 3 years ago
Woonsan Ko (migrated from Bugzilla): Discovered while testing https://github.com/apache/jmeter/issues/5413. Will try to find the root cause...
Woonsan Ko (migrated from Bugzilla): Fixes suggested and ready for review in PR: https://github.com/apache/jmeter/pull/631
The root cause:
HtmlReportAction.getMenuItemsAtLocation(MENU_LOCATION)
reads the translated label using the key, "generate_report_ui.html_report_menu", while its component name is "html_report".
CompileJSR223TestElements.getMenuItemsAtLocation(MENU_LOCATION)
uses "compile_menu" while its name is "compile_jsr223".
SchematicView.getMenuItemsAtLocation(MENU_LOCATION)
uses "schematic_view_menu" while its name is "schematic_view".
ParseCurlCommandAction.getMenuItemsAtLocation(MENU_LOCATION)
uses "curl_import_menu" while its name is "import_curl".
JMeterMenuBar.updateMenuElement(MenuElement)
seems to reset the label by resolving the translated label by using the component name, "html_report", as the key (L738-) for example.
I assume that it was designed originally to use the action component name as the menu item label resource key.
So, it was caused by the fact that each phase - (a) initial menu label resolution and (b) resetting the menu label on language switching in JMeterMenuBar - uses different keys for those menu item components.
Based on my assumption ("...designed originally to use the action component name as the menu item label resource key"), the PR suggests to use the action component name as the keys consistently.
Woonsan Ko (migrated from Bugzilla): Thank you!
Woonsan Ko (Bug 64800):
Created attachment tools2.png: Labels of some tools menu items are gone when switching to French
Severity: normal OS: All