search

apache / jmeter

Apache JMeter open-source load testing tool for analyzing and measuring the performance of a variety of services
https://jmeter.apache.org/
Apache License 2.0
8.43k stars 2.11k forks source link

feat: Add checkbox to enable/disable params in HTTP Sampler #6291

Open pochopsp opened 5 months ago

pochopsp commented 5 months ago

Description

This pull request adds a new column in the HTTP Sampler parameters table which allows the user to enable or disable the http parameter.

To implement this feature, a new "isEnabledFromGui" property has been added in HTTPArgument and it has been used in several places (HTTPHC4Impl, HTTPSamplerBase, PutWriter etc.) to determine whether to include the argument in the request or not. To enable the property setting by the user a new column has been added in HTTPArgumentsPanel. The HTTPArgumentSchema has been adjusted to include this new field too. Tests file and localization files has been adjusted to be compliant with this new attribute.

Motivation and Context

I think this feature could be really useful, because sometimes I and other people I know wished JMeter had it while doing some tests. Fixes https://github.com/apache/jmeter/issues/5466

How Has This Been Tested?

I have successfully built the project by using ./gradlew build and all tests ran without issues. My testing environment is Windows 10, Intel I5 6th gen, 16GB Ram DD4, Oracle JDK 17.

Screenshots (if appropriate):

image image

Types of changes

Checklist:

pochopsp commented 5 months ago

Hi @vlsi could you please help me on that? I don't really have a clue on why these tests are failing...

pochopsp commented 5 months ago

@vlsi I've also ran on my machine the task :src:dist-check:batchResponseDecompression which is failing in 17, microsoft, windows, America/New_York, tr_TR and it ran successfully image

vlsi commented 3 weeks ago

@pochopsp, have you tried using the default org.apache.jmeter.testelement.TestElementSchema#getEnabled for the attributes? Is there a need for a separate property?

pochopsp commented 2 weeks ago

@vlsi you were right, there is no need for a new property in the HTTArgumentSchema. I updated my pull request with commits including the use of org.apache.jmeter.testelement.TestElementSchema.enabled as you suggested. Furthermore, by doing so the number of edited files decreased to just six.