search

apache / jmeter

Apache JMeter open-source load testing tool for analyzing and measuring the performance of a variety of services
https://jmeter.apache.org/
Apache License 2.0
7.97k stars 2.02k forks source link

Prompt to save Test Plan on exit #845

Closed asfimport closed 21 years ago

asfimport commented 22 years ago

Martin Ramshaw (Bug 8801): When exiting, the following message is printed:

Note to self, we should really prompt to save here... (bb)

I will post a suggested patch shortly.

The tricky part is deciding which object should be aware of the 'dirtiness' of the test plan (I am leaning towards the TreeModel [as in GuiPackage.getInstance().getTreeModel()] although there are probably better candidates).

'Save' should clear the 'dirtiness' of the test plan, although 'Save' may have only saved a portion of the test plan (is this by design? Saving can be done at the node level; I have been caught by this at least once).

As well, there are probably many places where the test plan should be set to dirty - but only the 'Save' can clear this (even 'Load'-ing a new test plan might only add to the test plan). Have I understood this correctly ? It doesn't seem to be possible to change test plans without closing down and restarting JMeter.

As a side note, would a ThreadGroup be a candidate ? Was it intended that there only be one of these per test plan ? (I know that it is possible to have more than one, but this might be an oversight).

OS: other

asfimport commented 22 years ago

Mike Stover (migrated from Bugzilla): To answer some of these questions: It might be best if each node tracked it's own "dirtiness". I would highly recommend concentrating on the new src_1 branch to tackle this, as I think it'll be easier there.

It is not necessary to close and restart JMeter to change test plans. You can easily remove elements from your tree, and replace them with new ones. Although one cannot copy/paste nodes or drag/drop, you can save-delete-reload-elsewhere any tree segment you like.

And it is intentional that multiple threadgroups can be used. This allows multiple completely different tests to run simultaneously.

asfimport commented 22 years ago

Martin Ramshaw (migrated from Bugzilla): Created attachment 8801-patch: Incomplete, but perhaps better than nothing. Apply at .../src_1

asfimport commented 22 years ago

Martin Ramshaw (migrated from Bugzilla): I like the new 'NumberFieldErrorListener' component.This is obviously a better way to handle things (most of the components inmy patch implement similiar code). As well, it should offer a substantialperformance improvement, as unnecessarily listening to keystrokes is a realkiller.Of course, if it is still desirable to monitor the state of the test plan,then more is required than just the numeric fields. I guess the interface'JMeterGUIComponent' would be the place to define this contract.Any comments (favourable or otherwise) on these thoughts or my patch ?

asfimport commented 22 years ago

Mike Stover (migrated from Bugzilla): Fixed in the src_1 code

asfimport commented 21 years ago

Jordi Salvat i Alabart (migrated from Bugzilla): Marking all bugs RESOLVED before JMeter 1.8's release date as VERIFIED. Yes, it's pretty poor QA procedure, but there's bugs here lingering since JMeter 1.6, and we need to clean up a little.

asfimport commented 21 years ago

Jordi Salvat i Alabart (migrated from Bugzilla): Bulk-closing all bugs RESOLVED before JMeter 1.8 release date.