KAFKA-17508: Adding some guard for fallback deletion logic

apache / kafka

Mirror of Apache Kafka

Apache License 2.0

28.39k stars 13.84k forks source link

KAFKA-17508: Adding some guard for fallback deletion logic #17154

Closed FrankYang0529 closed 5 days ago

FrankYang0529 commented 1 week ago

In KAFKA-16424, we added a fallback logic to delete the logs, but the file has no parent. It'd be better we have some guard from it.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

showuon commented 6 days ago

@FrankYang0529 , we have build fail in jdk8 scala 2.12: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-17154/2/cloudbees-pipeline-explorer/?filter=9

Please help fix it. Thanks.

FrankYang0529 commented 5 days ago

Hi @showuon, build fail in jdk 8 and scala 2.12 is fixed. Also, all failed cases in latest CI can pass on my laptop. Could you take a look? Thank you.

showuon commented 5 days ago

Retriggering CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-17154/6/

FrankYang0529 commented 5 days ago

Retriggering CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-17154/6/

Hi @showuon, thanks for triggering CI. The latest failed cases can pass on my laptop.