search

apache / karaf-minho

Apache Karaf Minho
https://karaf.apache.org/
Apache License 2.0
6 stars 5 forks source link

`minho-spring-boot` application manager should look for `spring-boot` type #42

Closed jbonofre closed 1 year ago

jbonofre commented 1 year ago

Currently, the minho-spring-boot application manager is looking for application type minho-spring-boot-module-manager-service due to the following code snippet:

                if (application.getType() == null) {
                    if (canHandle(application.getUrl())) {
                        applications.add(application);
                    }
                } else if (application.getType().equals(name())) {
                    applications.add(application);
                }

This is wrong as it uses name() method which is different from the expected type value.

jbonofre commented 1 year ago

It would be great to add couple of tests about that, at least loading minho.json with applications.