search

apache / karaf-minho

Apache Karaf Minho
https://karaf.apache.org/
Apache License 2.0
6 stars 5 forks source link

`ConfigService` should look for env variables/system properties automatically #9

Closed jbonofre closed 1 year ago

jbonofre commented 1 year ago

Currently, the ConfigService can only be populated:

  1. programmatically
  2. json config service
  3. properties config service

It would be great that:

  1. the config properties can look for env variables/system properties
  2. populated automatically by k8s ConfigMap
mattrpav commented 1 year ago

In the 'it would be great that': to include Kubernetes Secrets as well!

jbonofre commented 1 year ago

Yup

fpapon commented 1 year ago

@mattrpav k8s secrets are generally mapped to the value of env variables in the k8s deployment so I'm not sure what you mean.

jbonofre commented 1 year ago

Config is already looking for env variables and system properties (when using Config#getProperty(key) method). I'm closing this issue, we will create one dedicated for ConfigMap (probably in Apache Sunny).