search

apache / kibble-1

Apache Kibble - a tool to collect, aggregate and visualize data about any software project
https://kibble.apache.org/
Apache License 2.0
59 stars 28 forks source link

Consider moving /setup content to main directory #37

Closed turbaszek closed 4 years ago

turbaszek commented 4 years ago

It's rather uncommon to keep setup.py and requirements.txt in a separate directory so I would like to suggest moving it to main directory.

turbaszek commented 4 years ago

@Humbedooh what do you think? Is there any reason for keeping it in /setup?

turbaszek commented 4 years ago

Slightly related #38

michalslowikowski00 commented 4 years ago

Is it still valid?

turbaszek commented 4 years ago

@michalslowikowski00 I think we should still consider this idea. As a first step, I would suggest figuring what is in setup/makeaccount.py and structure this file a little bit. This seems to be a script that accepts some users' input. I think it may make sense to refactor it and then introduce kibble.py with argparser that would serve the purpose of both setup.py and makeaccount.py (probably two subcommands?), for example:

# instead of: python setup.py
python kibble.py setup -e elasticsearch -a -k

# instead of: python makeaccount.py
python kibble.py make_account -a

This would be a nice step toward making kibble a python package (see #38 ) so in the future users could simply do

kibble setup
kibble make_account

What do you think @sharanf @Humbedooh ?

michalslowikowski00 commented 4 years ago

Make sense.