search

apache / kibble-1

Apache Kibble - a tool to collect, aggregate and visualize data about any software project
https://kibble.apache.org/
Apache License 2.0
58 stars 27 forks source link

Introduce black formatting #54

Closed turbaszek closed 3 years ago

turbaszek commented 3 years ago

Description Introduce black formatting tool: https://github.com/psf/black

This can be easily done by adding a respectable hook to our pre-commit configuration.

Use case Make the code format consistent and follow Python community best practises.

Related Issues N/A

michalslowikowski00 commented 3 years ago

Can I take this? :)

turbaszek commented 3 years ago

Sure, but I would say that it would be best to have #47 to avoid any regression or confusion

michalslowikowski00 commented 3 years ago

Sure. I will wait.

turbaszek commented 3 years ago

@michalslowikowski00 we should be ready after #58

michalslowikowski00 commented 3 years ago

Sure. I will do it asap (today's evening). :)

michalslowikowski00 commented 3 years ago

@turbaszek Hm... Do we want to BLACK all files in repo? :)
https://github.com/michalslowikowski00/kibble/runs/1288974043?check_suite_focus=true

michalslowikowski00 commented 3 years ago

I see... The same case as Pylint. It will require some more work and more PR's. :)

turbaszek commented 3 years ago

I see... The same case as Pylint. It will require some more work and more PR's. :)

Black will be simple do introduce, just let's run it over all files 👍

turbaszek commented 3 years ago

This was done in #66