search

apache / kibble-1

Apache Kibble - a tool to collect, aggregate and visualize data about any software project
https://kibble.apache.org/
Apache License 2.0
59 stars 28 forks source link

Introduce pylint to increase code quality #55

Open turbaszek opened 4 years ago

turbaszek commented 4 years ago

Description Introduce pylint for code quality analysis: https://github.com/PyCQA/pylint

This can be easily done by adding a respectable hook to our pre-commit configuration. However, this may require a lot of changes to code and maybe better to split it into few commits in single PR.

Use case Increase code quality, follow Python community best practices and avoid regression in future.

Related Issues N/A

michalslowikowski00 commented 4 years ago

I will do it. Everyone loves quality. :) https://www.youtube.com/watch?v=jbJ6Ufl5Kkc&ab_channel=MichaelFish

michalslowikowski00 commented 4 years ago

Ok, it will require more work, as you said. Before submitting this PR'a I will fix the code to make it compliant with pylint: part by part. There will be few PR's. :)

turbaszek commented 4 years ago

@michalslowikowski00 the amount of work will depend on the number of errors. We can reduce them by adding more rules to ignored ones in pylintrc config file