apache / kvrocks-controller

Apache Kvrocks Controller is a cluster management tool for Apache Kvrocks.
https://kvrocks.apache.org/
Apache License 2.0
78 stars 42 forks source link

MinAliveSize and MaxFailureRatio lead failover in safe mode #108

Closed bbqccx closed 10 months ago

bbqccx commented 10 months ago

in my case, i have two computer, one computer have 8 kvrocks node, cluster have 16 nodes。 when one computer carsh or broken , then failover will in safe mode, "msg":"safe mode, loop ratio 0.40, allnodes: 16, failnodes: 7" beause MinAliveSize is 10,MaxFailureRatio is 0.4,failove will check "nodesCount > MinAliveSize && float64(len(c.tasks))/float64(nodesCount) > MaxFailureRatio"

We would like to be able to configure MinAliveSize and MaxFailureRatio through conf file

git-hulk commented 10 months ago

Thank you! To see if @uds5501 would like to take this.

uds5501 commented 10 months ago

Sure mas, will take a look into it!

git-hulk commented 10 months ago

Thanks @uds5501, don't hesitate to contact me if you have any question.