search

apache / kvrocks-controller

Apache Kvrocks Controller is a cluster management tool for Apache Kvrocks.
https://kvrocks.apache.org/
Apache License 2.0
78 stars 42 forks source link

Refactor the controller API and failover/migration #165

Closed git-hulk closed 2 months ago

git-hulk commented 2 months ago

This PR will continuously refactor the API and cluster migration/failover to make it easier to maintain and test.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.85414% with 374 lines in your changes are missing coverage. Please review.

Project coverage is 47.91%. Comparing base (7ca006b) to head (faf307b). Report is 3 commits behind head on unstable.

Files Patch % Lines
server/api/shard.go 33.03% 69 Missing and 6 partials :warning:
controller/cluster.go 0.00% 59 Missing :warning:
store/cluster_node.go 61.11% 50 Missing and 6 partials :warning:
store/store.go 59.42% 42 Missing and 14 partials :warning:
controller/controller.go 0.00% 48 Missing :warning:
store/cluster_shard.go 72.97% 23 Missing and 7 partials :warning:
controller/event_bus.go 0.00% 13 Missing :warning:
server/api/cluster.go 76.19% 9 Missing and 1 partial :warning:
server/api/handler.go 0.00% 7 Missing :warning:
server/api/node.go 0.00% 6 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## unstable #165 +/- ## ============================================= + Coverage 24.67% 47.91% +23.24% ============================================= Files 42 20 -22 Lines 3595 1609 -1986 ============================================= - Hits 887 771 -116 + Misses 2597 740 -1857 + Partials 111 98 -13 ``` | [Flag](https://app.codecov.io/gh/apache/kvrocks-controller/pull/165/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/kvrocks-controller/pull/165/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.91% <50.85%> (+23.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.