apache / kvrocks-controller

Apache Kvrocks Controller is a cluster management tool for Apache Kvrocks.
https://kvrocks.apache.org/
Apache License 2.0
78 stars 42 forks source link

Refactor the implementation of the controller's probe and migration #167

Closed git-hulk closed 2 months ago

git-hulk commented 2 months ago

Before this PR, the API and controller are very hard to add test cases since we don't design any interface for this purpose. Many components are designed as an async mode by default which is not necessary.

So we have resolved those issues by using the sync mode and adding more interfaces to make it easier to mock and test.

git-hulk commented 2 months ago

I'm sorry for this PR is hard to review with so many changes, but the good news is most of them have test cases for now.