codecov-commenter
commented
4 months ago Codecov Report
Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
Project coverage is 57.41%. Comparing base (
f4f3be0) to head (84ad65e). Report is 1 commits behind head on unstable.
| Files | Patch % | Lines |
|---|---|---|
| store/cluster.go | 41.66% | 6 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## unstable #189 +/- ## ============================================= + Coverage 43.35% 57.41% +14.05% ============================================= Files 37 20 -17 Lines 2973 2024 -949 ============================================= - Hits 1289 1162 -127 + Misses 1544 724 -820 + Partials 140 138 -2 ``` | [Flag](https://app.codecov.io/gh/apache/kvrocks-controller/pull/189/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/kvrocks-controller/pull/189/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.41% <41.66%> (+14.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This closes #184
Currently, the controller only parsed the first slot range when importing the cluster. So it might be lost remain slot ranges if the shard has more than one slot range.