apache / kvrocks-controller

Apache Kvrocks Controller is a cluster management tool for Apache Kvrocks.
https://kvrocks.apache.org/
Apache License 2.0
84 stars 42 forks source link

Don't allow to create the cluster if the node has been initialized #92

Closed git-hulk closed 5 months ago

git-hulk commented 1 year ago

Currently, we didn't check if the node has been initialized and it may regenerate the node id for it. This would cause the node id was mismatched the cluster topology.

yeyypp commented 1 year ago

Hi,Does this issuee mean in the server/cluster.go Create function, we should check if storage exist a node with the same Addr as the req.Nodes?

git-hulk commented 1 year ago

@yeyypp We would like to check if the node has been initialized when creating. That's to say, if a node has the cluster information, then it cannot be joined as a new node.