search

apache / kvrocks-controller

Apache Kvrocks Controller is a cluster management tool for Apache Kvrocks.
https://kvrocks.apache.org/
Apache License 2.0
78 stars 42 forks source link

Use dns name for nodes #96

Closed paragor closed 11 months ago

paragor commented 12 months ago

https://github.com/RocksLabs/kvrocks_controller/blob/ef4a9453ea1a0adb84232769b4187ea0813687b0/server/cluster.go#L44

There is restriction - cluster's nodes should set by ip in config. But in k8s env kvrocks more often run as statefulset with static DNS name and dynamic IP address.

So, it would be cool if the controller could use dns names instead if ip addresses.

git-hulk commented 12 months ago

Hi @paragor

Thanks for your feedback, will fix this in the next version.

MateSousa commented 11 months ago

can i do it?

git-hulk commented 11 months ago

@MateSousa Definitely yes, thanks for your interest.