apache / kvrocks-controller

Apache Kvrocks Controller is a cluster management tool for Apache Kvrocks.
https://kvrocks.apache.org/
Apache License 2.0
78 stars 42 forks source link

Fix don't allow the domain name when creating the cluster #97

Closed MateSousa closed 11 months ago

MateSousa commented 11 months ago

This closes #96

git-hulk commented 11 months ago

Hi @MateSousa

Thanks for your contribution, would you mind transferring your contribute codes to the Apache group? If yes, please help to reply at https://github.com/RocksLabs/kvrocks_controller/issues/94 before merging.

codecov-commenter commented 11 months ago

Codecov Report

Merging #97 (00b69e9) into unstable (3b35c8a) will decrease coverage by 8.84%. The diff coverage is 38.07%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           unstable      #97      +/-   ##
============================================
- Coverage     34.52%   25.68%   -8.84%     
============================================
  Files            21       31      +10     
  Lines          1683     2593     +910     
============================================
+ Hits            581      666      +85     
- Misses         1015     1834     +819     
- Partials         87       93       +6     
Flag Coverage Δ
unittests 25.68% <38.07%> (-8.84%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/client/client.go 7.14% <0.00%> (ø)
cmd/client/completer.go 0.00% <ø> (ø)
cmd/client/printer.go 0.00% <0.00%> (ø)
cmd/client/request.go 4.62% <ø> (ø)
metadata/node.go 84.61% <ø> (ø)
metadata/slot.go 65.60% <ø> (ø)
server/controller.go 0.00% <ø> (ø)
server/middleware.go 47.61% <ø> (ø)
server/util.go 81.81% <ø> (ø)
storage/failover.go 0.00% <0.00%> (ø)
... and 18 more

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more