search

apache / kvrocks

Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.
https://kvrocks.apache.org/
Apache License 2.0
3.39k stars 438 forks source link

The storage engine type can be awareness in Kvrocks #1966

Open git-hulk opened 7 months ago

git-hulk commented 7 months ago

Search before asking

Motivation

We're now supporting the speedb and rocksdb as its storage engine and maybe even more in the future. I believe it'd would be better to allow each engine to have its specific configurations.

Solution

We can export the engine type information to Kvrocks while building the source stage. Can also take a look at how the new encoding format is recognized: https://github.com/apache/kvrocks/blob/unstable/CMakeLists.txt#L222-L226

Are you willing to submit a PR?

MaheshMadushan commented 6 months ago

Hi, is this issue available? if so, shall I try on this?

git-hulk commented 6 months ago

@MaheshMadushan assigned, thank you!