Open git-hulk opened 7 months ago
Please assign it to me, thanks a lot :D
@LiuYuHui Thank you!
Hi @LiuYuHui Are you still working on this issue?
Hi @git-hulk, I have had no extra time bandwidth recently, please feel free to assign it to other people.
@LiuYuHui Thanks for your quick response. Welcome back while you get time.
Hi @git-hulk , May i question? How do we implement this feature?
pubsub.max_write_buffer_number
、propagte.max_write_buffer_number
、zset_score.max_write_buffer_number
...lite
mode config, When this config is set to true
, create a new lite_table_opts
for infrequently used column families. like:
rocksdb::BlockBasedTableOptions lite_table_opts = InitTableOptions();
rocksdb::ColumnFamilyOptions lite_opts(subkey_opts);
lite_opts.write_buffer_size = 32 * MiB;
lite_opts.max_write_buffer_number = 0;
// replace subkey_opts with lite_opts
column_families.emplace_back(kZSetScoreColumnFamilyName, lite_opts);
column_families.emplace_back(kPubSubColumnFamilyName, lite_opts);
column_families.emplace_back(kPropagateColumnFamilyName, lite_opts);
column_families.emplace_back(kStreamColumnFamilyName, lite_opts);```
@jjz921024 Yes, I'm good with this implementation. Would you like to submit a PR?
Yes, I want to try
@jjz921024 Assigned, thank you!
Search before asking
Motivation
Currently, all column families are shared the same number of write buffers which is unnecessary for infrequently used column families including
pubsub
,propagte
, andzset_score
. We can keep them to a const value like 1 to reduce the memory usage in some scenarios.Solution
No response
Are you willing to submit a PR?