apache / kvrocks

Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.
https://kvrocks.apache.org/
Apache License 2.0
3.55k stars 466 forks source link

Reduce the number of write buffers for infrequently used column families #2193

Open git-hulk opened 7 months ago

git-hulk commented 7 months ago

Search before asking

Motivation

Currently, all column families are shared the same number of write buffers which is unnecessary for infrequently used column families including pubsub, propagte, and zset_score. We can keep them to a const value like 1 to reduce the memory usage in some scenarios.

Solution

No response

Are you willing to submit a PR?

LiuYuHui commented 7 months ago

Please assign it to me, thanks a lot :D

git-hulk commented 7 months ago

@LiuYuHui Thank you!

git-hulk commented 7 months ago

Hi @LiuYuHui Are you still working on this issue?

LiuYuHui commented 7 months ago

Hi @git-hulk, I have had no extra time bandwidth recently, please feel free to assign it to other people.

git-hulk commented 7 months ago

@LiuYuHui Thanks for your quick response. Welcome back while you get time.

jjz921024 commented 7 months ago

Hi @git-hulk , May i question? How do we implement this feature?

  1. For each column family add a config, specifying its number of write buffers. eg: pubsub.max_write_buffer_numberpropagte.max_write_buffer_numberzset_score.max_write_buffer_number ...
  2. Add a lite mode config, When this config is set to true, create a new lite_table_opts for infrequently used column families. like:

rocksdb::BlockBasedTableOptions lite_table_opts = InitTableOptions();
rocksdb::ColumnFamilyOptions lite_opts(subkey_opts);
lite_opts.write_buffer_size = 32 * MiB;
lite_opts.max_write_buffer_number = 0;

// replace subkey_opts with lite_opts 
column_families.emplace_back(kZSetScoreColumnFamilyName, lite_opts);
column_families.emplace_back(kPubSubColumnFamilyName, lite_opts);
column_families.emplace_back(kPropagateColumnFamilyName, lite_opts);
column_families.emplace_back(kStreamColumnFamilyName, lite_opts);```
git-hulk commented 7 months ago

@jjz921024 Yes, I'm good with this implementation. Would you like to submit a PR?

jjz921024 commented 7 months ago

Yes, I want to try

git-hulk commented 7 months ago

@jjz921024 Assigned, thank you!