apache / kvrocks

Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.
https://kvrocks.apache.org/
Apache License 2.0
3.47k stars 448 forks source link

Enable CompactionChecker for "search" CF #2263

Open mapleFU opened 4 months ago

mapleFU commented 4 months ago

Search before asking

Motivation

https://github.com/apache/kvrocks/blob/899216db7316083b5de9cef03dd0e818ededed96/src/server/server.cc#L200-L201

Should we enable compaction checker in this checking?

Solution

          std::vector<std::string> cf_names = {engine::kMetadataColumnFamilyName, engine::kSubkeyColumnFamilyName,
                                               engine::kZSetScoreColumnFamilyName, engine::kStreamColumnFamilyName};
          for (const auto &cf_name : cf_names) {
            compaction_checker.PickCompactionFiles(cf_name);
          }

Add type in this list

Are you willing to submit a PR?

mapleFU commented 4 months ago

@PragmaTwice