search

apache / kvrocks

Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine and is compatible with Redis protocol.
https://kvrocks.apache.org/
Apache License 2.0
3.56k stars 466 forks source link

Proposal: add multiple platforms and CPUs build workflow in GitHub Actions #572

Closed git-hulk closed 2 years ago

git-hulk commented 2 years ago

Search before asking

Motivation

As far as I know, Kvrocks works well on platforms like CentOS/Ubuntu/Debian and MacOSX, as well as CPU like ARM64 and Apple M1. But we didn't check the build system status now and we can't guarantee it's always fine over time. So I think we should check those statuses periodically.

Solution

For most PRs won't affect the build system status, but it's a bit time and resource costly. The workaround is to check daily or weekly instead of every PR, and we can fix them in time when anyone was broken. Do you guys have any thoughts?

Are you willing to submit a PR?

tisonkun commented 2 years ago

IIRC GitHub Actions doesn't provide hosted ARM64 machine (another instance). We may need a sponsor for self-hosted runners, other CI platform or ask ASF Infra for more information.

git-hulk commented 2 years ago

Thanks @tisonkun.

Another solution can run those ARM64 jobs on Travis CI, but I'm wondering whether it makes sense or not.

tisonkun commented 2 years ago

Closed as now we're using Travis to achieve multiple platform supports. If GitHub Actions support ARM platform later, we can review this proposal.