Closed cfmcgrady closed 2 years ago
cc @pan3793
how about 1.5?
kyuubi-server/src/test/java/org/apache/thrift/transport/TFramedTransport.java
should be moved from test scope to compile scope
@pan3793 , IMO, the TFramedTransport
should be moved to compile scope in the modules which use this.
@yaooqinn WDYT?
+1
Due to lack of test coverage and up coming 1.5 release, I propose to revert [KYUUBI #1948] Upgrade thrift version to 0.16.0
in branch-1.5
, we can continue add the test in master branch in the future.
@pan3793 @yaooqinn, IMO, [KYUUBI #1948] Upgrade thrift version to 0.16.0
doesn't need to revert in branch-1.5. At present, only find this bug for the upgrade. The previous bug of the fb303 has nothing with the upgrade.
Due to lack of test coverage and up coming 1.5 release, I propose to revert
[KYUUBI #1948] Upgrade thrift version to 0.16.0
inbranch-1.5
, we can continue add the test in master branch in the future.
+1
Technically, shading shall have fixed the issues we have met. But considering Spark(have reverted) and hive stays in 0.9, I am +1 for reverting it temporarily in 1.5 and keeping it in master
Another error occurs after changing the scope to compile.
@pan3793 @yaooqinn , does the hive-service-rpc version need to downgrade?
No, hive-service-rpc 3.1 is compatible with thrift 0.9
Looks like we need to revert on master branch due to the last issue reported by @cfmcgrady
Code of Conduct
Search before asking
Describe the bug
Affects Version(s)
master
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?