apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 917 forks source link

Support checks for Iceberg system procudures in Authz #5406

Open bowenliang123 opened 1 year ago

bowenliang123 commented 1 year ago

Code of Conduct

Search before creating

Mentor

Skill requirements

Background and Goals

Iceberg provides a series of system procedures for lifecycle management, which are essential for the lakehouse's administrator and users. And multiple plans may be executed in single procedure. Now the Authz plugin supports checking privileges for DMLs and DDLs on Iceberg tables, but system procedures are not in the range. It leaves a permission leaking to the Iceberg table management.

Doc reference: https://iceberg.apache.org/docs/latest/spark-procedures/ This task is targeted to ensure privilege checking on the Spark system procedures of Iceberg, including:

Implementation steps

  1. Create e-2-e tests for Iceberg in Authz tests for each procedures
  2. Prepare and provide proper test cases for positive and negative conditions in each procedure
  3. Solve the unsupported logical plans of the procedures, which may have multiple plans in single procedure

Additional context

No response

bowenliang123 commented 1 year ago

cc @yabola @AngersZhuuuu

bowenliang123 commented 1 year ago

Hi @pan3793 , it fails to assign this issue to @yabola on the right sidebar. How to achieve it?

pan3793 commented 1 year ago

it requires the contributor to leave some comments under the issue before assigning

bowenliang123 commented 1 year ago

it requires the contributor to leave some comments under the issue before assigning

Hi @yabola , would you like to accept this issue and leave a comment here ?

yabola commented 1 year ago

I can take this task~

bowenliang123 commented 1 year ago

I can take this task~

Thank you @yabola . Look forward to your following pull requests.