apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 916 forks source link

Track the client ip for internal kyuubi RESTful requests #6669

Closed turboFei closed 2 months ago

turboFei commented 2 months ago

:mag: Description

Issue References ๐Ÿ”—

As title, track the clientIp for internal kyuubi RESTful requests. Likes

Describe Your Solution ๐Ÿ”ง

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes :bookmark:

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (dff40e8) to head (87f144e). Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/org/apache/kyuubi/client/RestClient.java 0.00% 10 Missing :warning:
...ain/java/org/apache/kyuubi/client/IRestClient.java 0.00% 9 Missing :warning:
...ache/kyuubi/server/api/v1/InternalRestClient.scala 0.00% 8 Missing :warning:
...in/java/org/apache/kyuubi/client/BatchRestApi.java 0.00% 7 Missing :warning:
.../apache/kyuubi/server/api/v1/BatchesResource.scala 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6669 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 683 684 +1 Lines 42205 42233 +28 Branches 5756 5755 -1 ====================================== - Misses 42205 42233 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

turboFei commented 2 months ago

cc @pan3793 @zwangsheng

turboFei commented 2 months ago

thanks all, merged to 1.10.0