search

apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 916 forks source link

Format the kyuubi-ctl batch command output #6680

Closed turboFei closed 2 months ago

turboFei commented 2 months ago

:mag: Description

Issue References 🔗

As title, format the batch command output.

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes :bookmark:

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

Be nice. Be informative.

wForget commented 2 months ago

Related style error:

Error: ] /home/runner/work/kyuubi/kyuubi/kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/submit/SubmitBatchCommand.scala:20: Unused import
turboFei commented 2 months ago

spotless can not resolve the unused import issue for scala.

Should we involve a script lint-scala to check the scala style fast?

@wForget @pan3793

wForget commented 2 months ago

Should we involve a script lint-scala to check the scala style fast?

Sounds good to me.

turboFei commented 2 months ago

thanks, merged to 1.10.0/1.9.3

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (db5ce0c) to head (f9de99b). Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...che/kyuubi/ctl/cmd/submit/SubmitBatchCommand.scala 0.00% 2 Missing :warning:
...che/kyuubi/ctl/cmd/delete/DeleteBatchCommand.scala 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6680 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42233 42279 +46 Branches 5755 5765 +10 ====================================== - Misses 42233 42279 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.