apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.

Apache License 2.0

2.11k stars 916 forks source link

:mag: Description

Issue References 🔗

This pull request fixes #6615

Describe Your Solution 🔧

Add a config item that controls whether Jetty should send its version in response.

This is an additional patch which enables/disables sending Jetty version for prometheus reporter.

Sending Jetty version could be disabled by calling HttpConfiguration::setSendServerVersion(false)

Types of changes :bookmark:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Compiled and tested manually.

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (edbe3f3) to head (0638a51). Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...che/kyuubi/metrics/PrometheusReporterService.scala	0.00%	11 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6685 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42237 42247 +10 Branches 5755 5755 ====================================== - Misses 42237 42247 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.