apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 916 forks source link

[KYUUBI #6686] Ignore Spark pod container state if pod is terminated #6690

Closed turboFei closed 2 months ago

turboFei commented 2 months ago

:mag: Description

Issue References ๐Ÿ”—

To close #6686

image

The pod already in failed state, and the driver container is in waiting state.

We shall mark the application terminated and ignore the container state.

Describe Your Solution ๐Ÿ”ง

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes :bookmark:

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (db5ce0c) to head (0d4c8a2). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...kyuubi/engine/KubernetesApplicationOperation.scala 0.00% 15 Missing :warning:
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6690 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42233 42244 +11 Branches 5755 5756 +1 ====================================== - Misses 42233 42244 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

turboFei commented 2 months ago

thanks, merged to 1.0.0.