apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.

https://kyuubi.apache.org/

Apache License 2.0

2.11k stars 916 forks source link

[KYUUBI #6666][AUTHZ]Upgrade Ranger plugin to 2.5.0 #6692

Closed Madhukar525722 closed 2 months ago

Madhukar525722 commented 2 months ago

:mag: Description

Issue References 🔗

This pull request fixes #6666

Describe Your Solution 🔧

Bump ranger version to 2.5.0 Release notes: https://cwiki.apache.org/confluence/display/RANGER/Apache+Ranger+2.5.0+-+Release+Notes

Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

yaooqinn commented 2 months ago

Can we make the CI happy? Thank you @Madhukar525722

Madhukar525722 commented 2 months ago

Sure, I will work. Spark tests are failing with

check ranger policy file FAILED Line 24 is not expected. The file (/home/runner/work/kyuubi/kyuubi/extensions/spark/kyuubi-spark-authz/src/test/resources/sparkSql_hive_jenkins.json) is out of date. Please regenerate it by running dev/gen/gen_ranger_policy_json.sh. Expected " "[policyItems" : [ {]", but got " "[conditions" : [ ],]" (PolicyJsonFileGenerator.scala:79)

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (7198c72) to head (88e1e12). Report is 11 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6692 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42237 42279 +42 Branches 5755 5765 +10 ====================================== - Misses 42237 42279 +42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Madhukar525722 commented 2 months ago

HI @yaooqinn , CI is smiling. Please review cc @bowenliang123 After running the policy generator and updating the json. The test was failing due to order mismatch. Thats why I have used serialisation.

pan3793 commented 2 months ago

Thanks, merged to master