Open Madhukar525722 opened 2 months ago
Attention: Patch coverage is 0%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
550f1fc
) to head (062cd08
). Report is 53 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java | 0.00% | 18 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
and cc @pan3793
Hi @pan3793 , Please review the change
what about kyuubiServerPrincipal
and pricipal
?
Hi @pan3793, Actually the need for kyuubiServerPrincipal was not mentioned in the issue. I will be adding it as well, soon. cc @wForget
what about
kyuubiServerPrincipal
andpricipal
?
My original intention was to pass in the client's authentication information in properties. kyuubiServerPrincipal can be provided by zk and we don't need to get it here.
kyuubiServerPrincipal
can be provided by zk
this is disabled by default, because the lower Hive client does not support parsing that.
It would be weird if kyuubiClientPrincipal
works but kyuubiServerPrincipal
does not. Let's keep them synced to avoid surprising users.
Hi @pan3793 , I have updated the required. Please review
HI @pan3793, Gentle ping
LGTM, thank you, @Madhukar525722, please update the PR title and desc to match the code
HI @pan3793, I have changed as suggested.
โฆab from JDBC connection properties
:mag: Description
Issue References ๐
This pull request fixes #6689
Describe Your Solution ๐ง
It extracts the values of AUTH_KYUUBI_CLIENT_PRINCIPAL, AUTH_KYUUBI_CLIENT_KEYTAB, AUTH_KYUUBI_SERVER_PRINCIPAL and AUTH_PRINCIPAL, then passes it to connParams , to be used for establishing connections.
Types of changes :bookmark:
Test Plan ๐งช
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests
Checklist ๐
Be nice. Be informative.