turboFei commented 2 months ago

:mag: Description

Issue References 🔗

Followup for #6681

We shall log the kill batch request before or inside closeSession, as it will close the operation log.

Describe Your Solution 🔧

log the kill batch request before closeSession.
log the kill batch response in BatchJobSubmission::close.

Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8e2b1b3) to head (13dbf4a). Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
...g/apache/kyuubi/operation/BatchJobSubmission.scala	0.00%	4 Missing :warning:
.../apache/kyuubi/server/api/v1/BatchesResource.scala	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6697 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42279 42281 +2 Branches 5765 5766 +1 ====================================== - Misses 42279 42281 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.