apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 915 forks source link

support list server configs by admin cli tool #6702

Open bowenliang123 opened 2 months ago

bowenliang123 commented 2 months ago

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes #

Describe Your Solution ๐Ÿ”ง

Types of changes :bookmark:

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8056235) to head (1c1d58d). Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/kyuubi/client/api/v1/dto/ConfigEntry.java 0.00% 17 Missing :warning:
...e/kyuubi/ctl/cmd/list/AdminListConfigCommand.scala 0.00% 7 Missing :warning:
...rg/apache/kyuubi/server/api/v1/AdminResource.scala 0.00% 6 Missing :warning:
...in/java/org/apache/kyuubi/client/AdminRestApi.java 0.00% 5 Missing :warning:
...main/scala/org/apache/kyuubi/ctl/util/Render.scala 0.00% 4 Missing :warning:
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 3 Missing :warning:
...a/org/apache/kyuubi/ctl/opt/AdminCommandLine.scala 0.00% 2 Missing :warning:
...ache/kyuubi/ctl/cli/AdminControlCliArguments.scala 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6702 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 686 +2 Lines 42279 42324 +45 Branches 5765 5770 +5 ====================================== - Misses 42279 42324 +45 ``` | [Flag](https://app.codecov.io/gh/apache/kyuubi/pull/6702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage ฮ” | | |---|---|---| | [](https://app.codecov.io/gh/apache/kyuubi/pull/6702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pan3793 commented 2 months ago

listing configurations should be restricted to admin only. additionally, we may need to have another parameter to define the display mode for configuration values, e.g.

PS: I remember there was a similar request to have a configuration display mode of configurations for retrieving batch info