pan3793 commented 2 months ago

:mag: Description

Issue References 🔗

The server module does not consume the spark-sql-engine classes, but it supposes that spark-sql-engine's jar existed on the target folder, so here we declare it as a dependency to make sure that Maven always processes spark-sql-engine module before the server module. IntelliJ IDEA 2024.1 fixed the IDEA-93855, thus the relocated classes inside the spark-sql-engine's shaded jar are visible in the server module in IDEA, for example, org.apache.kyuubi.shaded.spark.connect.proto.ExecutePlanRequest, which silently breaks the IDEA code analysis and jumping capabilities.

Describe Your Solution 🔧

Changing the dependency type from jar(default value) to pom seems to be a workaround.

Types of changes :bookmark:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (8056235) to head (a73fd42). Report is 2 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6708 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42279 42279 Branches 5765 5765 ====================================== Misses 42279 42279 ``` | [Flag](https://app.codecov.io/gh/apache/kyuubi/pull/6708/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/apache/kyuubi/pull/6708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.