apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 915 forks source link

[KYUUBI #6709] Fix seq and set equals check bug while check auth type in AuthenticationFilter.initAuthHandlers #6711

Closed lifulong closed 1 month ago

lifulong commented 1 month ago

:mag: Description

Issue References πŸ”—

This pull request fixes #6709

Describe Your Solution πŸ”§

transfer the type of authTypes from seq to set before do equals check

Types of changes :bookmark:

Test Plan πŸ§ͺ

test in our produce kyuubi env

Behavior Without This Pull Request :coffin:

image image

always hint to login in all sub tabs of management tab in kyuubi web ui, but can not login in actually, while use confkyuubi.authentication NOSASL, and our java version is 1.8 scala version is 2.12.18

Behavior With This Pull Request :tada:

image

Related Unit Tests

none, no need i think

Checklist πŸ“

Be nice. Be informative.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (ebe7e92) to head (850bda4). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ver/http/authentication/AuthenticationFilter.scala 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6711 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42281 42281 Branches 5766 5766 ====================================== Misses 42281 42281 ``` | [Flag](https://app.codecov.io/gh/apache/kyuubi/pull/6711/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | | |---|---|---| | [](https://app.codecov.io/gh/apache/kyuubi/pull/6711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lifulong commented 1 month ago

@pan3793 @ulysses-you @turboFei anyone have time review this change ?

lifulong commented 1 month ago

thx for review @pan3793 @turboFei , but how to merge, looks like i have no permission to mege

turboFei commented 1 month ago

thanks @lifulong merged to master/branch-1.9/branch-1.8