apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 915 forks source link

[KYUUBI #6720] K8s pod OOM Killed should be identified as Application failed state #6721

Closed Madhukar525722 closed 1 month ago

Madhukar525722 commented 1 month ago

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes #6720

Describe Your Solution ๐Ÿ”ง

If pod goes into OOMKilled state, application should be marked as KILLED, which is eventually identified as isFailed

Types of changes :bookmark:

Test Plan ๐Ÿงช

Tested locally, was able to launch new session

kyuubi_new_session

Be nice. Be informative.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (372f770) to head (cd0bdf6). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...kyuubi/engine/KubernetesApplicationOperation.scala 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6721 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 684 684 Lines 42281 42282 +1 Branches 5766 5767 +1 ====================================== - Misses 42281 42282 +1 ``` | [Flag](https://app.codecov.io/gh/apache/kyuubi/pull/6721/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage ฮ” | | |---|---|---| | [](https://app.codecov.io/gh/apache/kyuubi/pull/6721/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pan3793 commented 1 month ago

Thanks, merged to master/1.9