Open taylor12805 opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 0.00%. Comparing base (
2d64255
) to head (6646c95
). Report is 52 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
๐จ Try these New Features:
@taylor12805 Before submitting the pull request, we can use ./dev/reformat to format the code.
@taylor12805 Before submitting the pull request, we can use ./dev/reformat to format the code.
@lsm1 thanks for reminding. I added test case for trino statement progress, however since trino don't have sleep function, I can't mock multiple stages case. Do you have some ideas?
@taylor12805* Before submitting the pull request, we can use ./dev/reformat to format the code.
@lsm1* thanks for reminding. I added test case for trino statement progress, however since trino don't have sleep function, I can't mock multiple stages case. Do you have some ideas?
Adding a sleep function in Trino is not straightforward, so simple unit tests should be sufficient for now.
@taylor12805 Please fix the failing test
- get operation progress *** FAILED ***
The code passed to eventually never returned normally. Attempted 1623 times over 25.002736579 seconds. Last failure message: Expected List("Stage-0 ........", "FINISHED", "5", "5", "0", "0", "0", ""), but got Buffer("Stage-0 ........", "FINISHED", "3", "3", "0", "0", "0", ""). (TrinoOperationProgressSuite.scala:43)
:mag: Description
Issue References ๐
This pull request fixes https://github.com/apache/kyuubi/issues/6726
Describe Your Solution ๐ง
Add trino statement progress
Types of changes :bookmark:
Test Plan ๐งช
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests
Checklist ๐
Be nice. Be informative.