search

apache / kyuubi

Apache Kyuubi is a distributed and multi-tenant gateway to provide serverless SQL on data warehouses and lakehouses.
https://kyuubi.apache.org/
Apache License 2.0
2.11k stars 914 forks source link

Fix ProcessBuilder to properly handle Java opts as a list #6772

Closed lsm1 closed 1 month ago

lsm1 commented 1 month ago

:mag: Description

Issue References 🔗

Describe Your Solution 🔧

This PR addresses an issue in the ProcessBuilder class where Java options passed as a single string (e.g., "-Dxxx -Dxxx") do not take effect. The command list must separate these options into individual elements to ensure they are recognized correctly by the Java runtime.

Types of changes :bookmark:

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

Be nice. Be informative.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (be66b49) to head (fb6d532). Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
.../apache/kyuubi/util/command/CommandLineUtils.scala 0.00% 53 Missing :warning:
...apache/kyuubi/engine/jdbc/JdbcProcessBuilder.scala 0.00% 2 Missing :warning:
...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala 0.00% 1 Missing :warning:
...apache/kyuubi/engine/hive/HiveProcessBuilder.scala 0.00% 1 Missing :warning:
...ache/kyuubi/engine/trino/TrinoProcessBuilder.scala 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6772 +/- ## ======================================= Coverage 0.00% 0.00% ======================================= Files 684 684 Lines 42281 43076 +795 Branches 5768 5877 +109 ======================================= - Misses 42281 43076 +795 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bowenliang123 commented 1 month ago

Thanks, merged to master , branch-1.10 (1.10.0) and branch-1.9 (1.9.3).