bowenliang123 commented 4 weeks ago

:mag: Description

Issue References 🔗

Describe Your Solution 🔧

previously, pnpm install and npm install are forced to inherits HTTP proxy configs from Maven by the frontend maven plugin (https://github.com/eirslett/frontend-maven-plugin?tab=readme-ov-file#proxy-settings)
adding a parameter maven.plugin.frontend.inheritsProxyConfigFromMave to control whether it inherits the proxy configs with false as default value

Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (d3520dd) to head (c8eb2e4). Report is 4 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6778 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 687 687 Lines 42439 42439 Branches 5793 5793 ====================================== Misses 42439 42439 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bowenliang123 commented 1 week ago

Thanks, merged to master (1.11.0) and branch-1.10 (1.10.1).

apache / kyuubi

[BUILD] allow frontend plugin not to inherits Maven's http proxy config #6778