Open turboFei opened 3 weeks ago
Attention: Patch coverage is 0%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
d3520dd
) to head (78c2a6c
).
Files with missing lines | Patch % | Lines |
---|---|---|
...kyuubi/engine/KubernetesApplicationOperation.scala | 0.00% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:mag: Description
Issue References ๐
As title.
Fix NPE, because the cleanupTerminatedAppInfoTrigger will be set to
null
. https://github.com/apache/kyuubi/blob/d3520ddbcea96ec55c525600126047c44c7adb35/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala#L269Also shutdown the ExecutorService when KubernetesApplicationOperation stoped.
Describe Your Solution ๐ง
Shutdown the thread executor service and check the null.
Types of changes :bookmark:
Test Plan ๐งช
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests
Checklist ๐
Be nice. Be informative.