bowenliang123 commented 3 weeks ago

:mag: Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

TColumnGenerator is used for generating column-based data. This PR skips repeated checks on checking nullability of the convert function in generating single column.

Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (d3520dd) to head (f76f686). Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
...apache/kyuubi/engine/result/TColumnGenerator.scala	0.00%	7 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6786 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 687 687 Lines 42439 42439 Branches 5793 5793 ====================================== Misses 42439 42439 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bowenliang123 commented 1 week ago

Thanks, merged to master (1.11.0) and branch-1.10 (1.10.1).

apache / kyuubi

Skip repeated checks on convert function in TColumnGenerator #6786