lsm1 commented 3 weeks ago

:mag: Description

Issue References 🔗

This pull request fixes #2112

Describe Your Solution 🔧

Similar to #2113, the query-timeout-thread should verify the Thrift protocol version. For protocol versions <= HIVE_CLI_SERVICE_PROTOCOL_V8, it should convert TIMEDOUT_STATE to CANCELED.

Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (d3520dd) to head (9fbe1ac). Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...rg/apache/kyuubi/operation/AbstractOperation.scala	0.00%	5 Missing :warning:
...org/apache/kyuubi/operation/ExecuteStatement.scala	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6787 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 687 687 Lines 42439 42441 +2 Branches 5793 5793 ====================================== - Misses 42439 42441 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lsm1 commented 3 weeks ago

LGTM. Since 2112 was released very early, it is recommended to use the new Kyuubi ID instead of FOLLOWUP.

done

lsm1 commented 2 weeks ago

Thanks, merged to master

apache / kyuubi

Improve the compatibility of queryTimeout in more version clients #6787