wForget commented 2 weeks ago

:mag: Description

Issue References 🔗

Fix engine cannot exit when gracefully stopped

This pull request fixes #6790

Describe Your Solution 🔧

Types of changes :bookmark:

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklist 📝

[X] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c9d9433) to head (efe7a2f). Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...org/apache/kyuubi/ha/client/ServiceDiscovery.scala	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6792 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 687 687 Lines 42441 42442 +1 Branches 5793 5793 ====================================== - Misses 42441 42442 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

turboFei commented 2 weeks ago

thanks, merged to main/1.10/1.9/1.8.3

apache / kyuubi

[KYUUBI #6790] Fix engine cannot exit when gracefully stopped #6792