Open dimgal1 opened 3 years ago
I implemented a pull request that goes into the direction of making this more customizable
Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.
Summary
Enabling retry logic does not work for rate limit exceeded responses.
Detailed Information
retry decorator expects a
RateLimitExceeded
error to be raised, thoughsession.request
method does not raise an exception if a response is returned by the server no matter the status code.I've tested it on azure_arm driver by setting
RETRY_FAILED_HTTP_REQUESTS
to True and trying:Hitting the throttling limit results in:
urllib3 supports retries based on HTTP status codes, maybe use this? Let me know how you think this should be handled